-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] #68 - 바뀐 레이아웃 수정 작업 #69
Conversation
let pinImage = UIImage(named: "iconPin") | ||
_ = UIImage(named: "iconReorder") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이미지로 핀여부를 판단하는거 같은데요! 34번 줄은 요건 지금은 안쓰일 코드라서... 해둔건가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 이거쓰려다가 이미지를 안쓰게되서 필요없어진겁니닷!!
지울게요!
@@ -21,7 +21,7 @@ class SceneDelegate: UIResponder, UIWindowSceneDelegate { | |||
|
|||
window = UIWindow(frame: windowScene.coordinateSpace.bounds) | |||
window?.windowScene = windowScene | |||
window?.rootViewController = UIStoryboard(name: Const.Storyboard.Name.customTabBar, bundle: nil).instantiateViewController(withIdentifier: Const.ViewController.Identifier.customTabBarController) | |||
window?.rootViewController = UIStoryboard(name: Const.Storyboard.Name.tabBar, bundle: nil).instantiateViewController(withIdentifier: Const.ViewController.Identifier.tabBarViewController) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
탭바.. 아깝지만 민재의[도-약] 이라고 생각이 듭니당
/** | ||
공통으로 사용할 수 있도록 만들어둔 바텀 시트입니다. | ||
|
||
1) CommonBottomSheetViewController에는 공통으로 필요한 요소들만 구현해둔 상태 | ||
2) CommonBottomSheetViewController를 상속받은 뷰컨 생성 (예시: InheritanceViewController) | ||
3) InheritanceViewController에 텍스트 필드, 피커 뷰, 버튼 등 각 화면에 맞는 추가 기능 구현 | ||
4) .setHeight 메서드 파라미터로 높이값을 조정 (default값은 475) | ||
5) .setTitle 메서드 파라미터로 가장 상단 타이틀 라벨에 들어갈 내용 입력 (String) | ||
6) present 방식으로 화면에 표출 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
퀵헬프 주석까지.. 선배 최고얌!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
또 좋은거 하나 배워갑니다 ^__^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
친절해!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
민재야 짱 수고 했어 너 진짜 잘한다 진짜 쑥쑥느네
@IBOutlet weak var firstTmiLabel: UILabel! | ||
@IBOutlet weak var secondTmiLabel: UILabel! | ||
@IBOutlet weak var thirdTmiLabel: UILabel! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 그냥 꿀팁인데! 이렇게 성격이 같은? 근데 넘버링만 해주는 라벨 같은 경우는 outlet collection을 사용하면 조금 더 깔끔한 코드를 만들 수 있어용! 그러면 3개의 아울렛이 array로 묶여서 들어가거든! 그냥 꿀팁 전달입니당 굳이 고치진 않아도 될거같아요 ㅎㅎ 요거는 레퍼런스 ! https://hyerios.tistory.com/104
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호 이런거 너무좋아요 교수님👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다 그런데 그 배열에 뭐가 있는지 나중가서는 몰라서 주석을 잘 쓰지 않는다면 뭔가... 오히려 헷갈린다랄까요 암튼 유용합니다!! 프로페서이준 최고
/** | ||
공통으로 사용할 수 있도록 만들어둔 바텀 시트입니다. | ||
|
||
1) CommonBottomSheetViewController에는 공통으로 필요한 요소들만 구현해둔 상태 | ||
2) CommonBottomSheetViewController를 상속받은 뷰컨 생성 (예시: InheritanceViewController) | ||
3) InheritanceViewController에 텍스트 필드, 피커 뷰, 버튼 등 각 화면에 맞는 추가 기능 구현 | ||
4) .setHeight 메서드 파라미터로 높이값을 조정 (default값은 475) | ||
5) .setTitle 메서드 파라미터로 가장 상단 타이틀 라벨에 들어갈 내용 입력 (String) | ||
6) present 방식으로 화면에 표출 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
친절해!
bottomSheetCoverView.topAnchor.constraint(equalTo: bottomSheetView.topAnchor), | ||
bottomSheetCoverView.leadingAnchor.constraint(equalTo: bottomSheetView.leadingAnchor), | ||
bottomSheetCoverView.trailingAnchor.constraint(equalTo: bottomSheetView.trailingAnchor), | ||
bottomSheetCoverView.bottomAnchor.constraint(equalTo: bottomSheetView.bottomAnchor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우와 이거 스냅킷 안쓰고 했네 멋지다
view.addSubview(dimmedBackView) | ||
view.addSubview(bottomSheetView) | ||
view.addSubview(dismissIndicatorView) | ||
view.addSubview(titleLabel) | ||
view.addSubview(bottomSheetCoverView) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
유용한 addView 익스텐션 놔두고 갈게용~
extension UIView {
func addSubviews(_ view: [UIView]) {
view.forEach { self.addSubview($0) }
}
}
사용예제는 예를 들면 view.addSubviews([logoLabel, loginLabel, explainLabel]) 요렇게!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호,, 교수님 최고,,,,,ㅜㅠㅜㅠㅜ
private var firstAnswerList = [String]() | ||
private var secondQuestionList = [String]() | ||
private var secondAnswerList = [String]() | ||
private var firstTmiList = [String]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저 그냥 궁금한게 있는데 [String]()
요거는 머야?? 저렇게 하면 빈배열로 생성되는건가유??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거는 현규 선배의 방법을 참고한건데,
검색해보니깐 배열 초기화하는 또다른 방법이더라구요!
:[String] = []
랑 같은 역할이랍니다 ^__^
실행시간이 이게 더 빠르고, 배열을 만들고 있다는 것을 보여준다는데,, 저도 잘 정확히는 모르겠숩니다 ...^^
https://stackoverflow.com/questions/29199268/swift-difference-between-var-arrstring-and-var-arr-string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 오케이 궁금해서 물어봤어유 답변 고마워유우우우!!!
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📸 스크린샷
📮 관련이슈